Both are past 30.
Both pretty experienced.
Both previously right backs who probably don't have the legs for the modern attacking full back role.
Both probably more suited to playing in a back three.
Do we really need what is effectively two players filling the same role? Had I a choice of the two, I'd probably have renewed McGinn. But given O'Donnell renewed automatically, I'd have chosen to sacrifice McGinn in order to free up a salary for a younger defender with a bit more legs/energy/power..
But, hey, as it is they are both under contract now. I don't know how much value for money we'll get out of that fact, but not much we can do about it now..